[webkit-reviews] review granted: [Bug 211991] Some color-related cleanup : [Attachment 399577] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 211991: Some color-related cleanup
https://bugs.webkit.org/show_bug.cgi?id=211991

Attachment 399577: Patch

https://bugs.webkit.org/attachment.cgi?id=399577&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 399577
  --> https://bugs.webkit.org/attachment.cgi?id=399577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399577&action=review

> Source/WebCore/platform/graphics/Color.cpp:571
> +    float r, g, b, a;
> +    getRGBA(r, g, b, a);

Is there any good reason getRGBA() should take out parameters? Is it just for
ADL to distinguish between float and double? Is the double version really
necessary or used (I ask without looking)?