[webkit-reviews] review granted: [Bug 211952] [JSC] Make OutOfMemory error as instance of RangeError : [Attachment 399536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 15 20:07:48 PDT 2020


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 211952: [JSC] Make OutOfMemory error as instance of RangeError
https://bugs.webkit.org/show_bug.cgi?id=211952

Attachment 399536: Patch

https://bugs.webkit.org/attachment.cgi?id=399536&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 399536
  --> https://bugs.webkit.org/attachment.cgi?id=399536
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399536&action=review

r=me

> Source/JavaScriptCore/runtime/ErrorType.h:54
> +#define COUNT_ERROR_TYPES(name) 1 +
> +static constexpr unsigned NumberOfErrorType {
> +    JSC_ERROR_TYPES(COUNT_ERROR_TYPES) 0

Nice.  I never thought of doing it this way to do the counting.


More information about the webkit-reviews mailing list