[webkit-reviews] review granted: [Bug 211776] REGRESSION (iOS 13.4.1): SpeechSynthesisUtterance.onend event won't fire on cancel(). : [Attachment 399247] patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 211776: REGRESSION (iOS 13.4.1): SpeechSynthesisUtterance.onend event won't
fire on cancel().
https://bugs.webkit.org/show_bug.cgi?id=211776

Attachment 399247: patch

https://bugs.webkit.org/attachment.cgi?id=399247&action=review




--- Comment #10 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 399247
  --> https://bugs.webkit.org/attachment.cgi?id=399247
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399247&action=review

R=me.

>>> Source/WebCore/ChangeLog:3
>>> +	     REGRESSION (iOS 13.4.1): SpeechSynthesisUtterance.onend event
won't fire on cancel().
>> 
>> Obvious question: can a regression test be made for this issue?
> 
> we have one for the Mock synthesizer that goes all through WebCore. This one
uses the synthesizer in the client, which AFAICT there were no tests added for.
> 
> @Per, @Brent, is there a way to test this flow? Right now we use a mock
synthesizer in these tests that bypasses this logic that was fixed

I am not sure how to write a test for this. Is it possible to write a layout
test that does not use a mock synthesizer?

> Source/WebCore/ChangeLog:17
> +	   (WebCore::SpeechSynthesis::cancel):

Perhaps you could include an explanation here if creating a test is not
feasible.