[webkit-reviews] review granted: [Bug 195967] [css-grid] width/height:N% should make the minimum contribution be the minimum size, not the min-content contribution : [Attachment 399488] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 195967: [css-grid] width/height:N% should make the minimum contribution be
the minimum size, not the min-content contribution
https://bugs.webkit.org/show_bug.cgi?id=195967

Attachment 399488: Patch

https://bugs.webkit.org/attachment.cgi?id=399488&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 399488
  --> https://bugs.webkit.org/attachment.cgi?id=399488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399488&action=review

Thanks for fixing this, LGTM.

> Source/WebCore/ChangeLog:23
> +	   Some cases in the test still fail due to other issues.

Nit: Could you link to bug reports for the "other issues"?