[webkit-reviews] review granted: [Bug 188730] [Web Animations] Animation with a single keyframe is not accelerated : [Attachment 399492] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 188730: [Web Animations] Animation with a single keyframe is not
accelerated
https://bugs.webkit.org/show_bug.cgi?id=188730

Attachment 399492: Patch

https://bugs.webkit.org/attachment.cgi?id=399492&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 399492
  --> https://bugs.webkit.org/attachment.cgi?id=399492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399492&action=review

> Source/WebCore/rendering/style/KeyframeList.cpp:81
> +    return size() && (m_keyframes[0].key() || m_keyframes[size() - 1].key()
!= 1);

Are you sure m_keyframes has values?

> Source/WebCore/rendering/style/KeyframeList.cpp:103
> +	   static StyleRuleKeyframe* zeroPercentKeyframe;
> +	   if (!zeroPercentKeyframe) {
> +	       zeroPercentKeyframe =
&StyleRuleKeyframe::create(MutableStyleProperties::create()).leakRef();
> +	       zeroPercentKeyframe->setKey(0);
> +	   }

Should do the NeverDestroyed thing that smfr suggested.