[webkit-reviews] review denied: [Bug 209930] REGRESSION (iOS 13.4): Inset box-shadow rendering bug : [Attachment 399459] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied me at masonx.ca's request
for review:
Bug 209930: REGRESSION (iOS 13.4): Inset box-shadow rendering bug
https://bugs.webkit.org/show_bug.cgi?id=209930

Attachment 399459: Patch

https://bugs.webkit.org/attachment.cgi?id=399459&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 399459
  --> https://bugs.webkit.org/attachment.cgi?id=399459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399459&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2398
> -	       LayoutUnit xOffset = paintRect.width() + std::max<LayoutUnit>(0,
shadowOffset.width()) + shadowPaintingExtent + 2 * shadowSpread +
LayoutUnit(1);
> +	       LayoutUnit xOffset = paintRect.width() + std::max<LayoutUnit>(0,
shadowOffset.width()) + shadowPaintingExtent - 2 * shadowSpread +
LayoutUnit(1);

The bug is about inset shadows, but this is the Normal shadow code path, so
this can't be the right fix.