[webkit-reviews] review denied: [Bug 142933] Redefining a property should not change its insertion index (Object.keys order) : [Attachment 398787] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 142933: Redefining a property should not change its insertion index
(Object.keys order)
https://bugs.webkit.org/show_bug.cgi?id=142933

Attachment 398787: Patch

https://bugs.webkit.org/attachment.cgi?id=398787&action=review




--- Comment #12 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 398787
  --> https://bugs.webkit.org/attachment.cgi?id=398787
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398787&action=review

Looks nice. But I think some of Structures' flags are missing.

> Source/JavaScriptCore/runtime/Structure.cpp:676
> +    if (attributes & (PropertyAttribute::ReadOnly |
PropertyAttribute::Accessor))
> +	  
structure->setHasReadOnlyOrGetterSetterPropertiesExcludingProto(true);

Do we ensure that propertyName is not __proto__?

> Source/JavaScriptCore/runtime/Structure.cpp:677
> +

Is it OK not to set setHasGetterSetterProperties /
setHasCustomGetterSetterProperties etc. Can you review all the flags of
Structure?