[webkit-reviews] review granted: [Bug 211913] Attribute non-network loads and loads with html strings as automatically app-bound : [Attachment 399408] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 211913: Attribute non-network loads and loads with html strings as
automatically app-bound
https://bugs.webkit.org/show_bug.cgi?id=211913

Attachment 399408: Patch

https://bugs.webkit.org/attachment.cgi?id=399408&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 399408
  --> https://bugs.webkit.org/attachment.cgi?id=399408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399408&action=review

Looks good! I had a couple of minor suggestions.

> Source/WebKit/UIProcess/WebPageProxy.cpp:1394
> +    if (MIMEType == String("text/html") &&
!WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)

if (MIMEType == "text/html"_s &&
!WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN)

> Source/WebKit/UIProcess/WebPageProxy.cpp:3120
> +    return requestURL.protocolIsAbout() || requestURL.protocolIsData() ||
requestURL.protocolIsBlob() || requestURL.isLocalFile() ||
requestURL.protocolIsJavaScript();

Didn't Chris have some comment on a different URL method to use for this? I
can't find his comment right now. :-\