[webkit-reviews] review granted: [Bug 211914] Undecided Arrays shouldn't need to be OriginalArray to covert to GetArrayLength : [Attachment 399393] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 211914: Undecided Arrays shouldn't need to be OriginalArray to covert to
GetArrayLength
https://bugs.webkit.org/show_bug.cgi?id=211914

Attachment 399393: Patch

https://bugs.webkit.org/attachment.cgi?id=399393&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 399393
  --> https://bugs.webkit.org/attachment.cgi?id=399393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399393&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +	   bottom is the only possible value and insert a breakpoint, which

nit: AI doesn't insert a breakpoint :-)

FTL/DFG compilers, based on what AI says, will

> Source/JavaScriptCore/dfg/DFGArrayMode.cpp:243
> +	   // As long as we have a JSArray getting its length shouldn't require
any sane chainness.

JSArray => JSArray,