[webkit-reviews] review granted: [Bug 211166] [GStreamer] webrtc/disable-encryption.html is a crashing flaky : [Attachment 399120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 04:42:56 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 211166: [GStreamer] webrtc/disable-encryption.html is a crashing flaky
https://bugs.webkit.org/show_bug.cgi?id=211166

Attachment 399120: Patch

https://bugs.webkit.org/attachment.cgi?id=399120&action=review




--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 399120
  --> https://bugs.webkit.org/attachment.cgi?id=399120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399120&action=review

>>>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:59
1
>>> +	 GRefPtr<GstElement> src = gst_element_factory_make("appsrc", nullptr);
>> 
>> This `ref_sink` now?
> 
> Yes, through template <> GstElement* refGPtr<GstElement>() (AFAIK)

Yes, it is correct and this inconsistency between floating/full and not
adopting/adopting is something I wanted to change since ages.


More information about the webkit-reviews mailing list