[webkit-reviews] review granted: [Bug 211751] Replace isNullFunctionPointer with real weak-linking support : [Attachment 399273] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 13:44:34 PDT 2020


Sam Weinig <sam at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 211751: Replace isNullFunctionPointer with real weak-linking support
https://bugs.webkit.org/show_bug.cgi?id=211751

Attachment 399273: Patch

https://bugs.webkit.org/attachment.cgi?id=399273&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 399273
  --> https://bugs.webkit.org/attachment.cgi?id=399273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399273&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:37
> +WTF_WEAK_LINK_FORCE_IMPORT(webrtc::setApplicationStatus);

Interesting. I couldn't get this to work when I tried.


More information about the webkit-reviews mailing list