[webkit-reviews] review granted: [Bug 156435] composited scrolling interferes with the propagation of perspective : [Attachment 399281] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 156435: composited scrolling interferes with the propagation of perspective
https://bugs.webkit.org/show_bug.cgi?id=156435

Attachment 399281: Patch

https://bugs.webkit.org/attachment.cgi?id=399281&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 399281
  --> https://bugs.webkit.org/attachment.cgi?id=399281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399281&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:691
> +    auto layerForChildrenTransform = [&]() {

Unnecessary ()

> Source/WebCore/rendering/RenderLayerBacking.cpp:706
> +	   perspectiveRelativeBox = borderBoxRect;
> +	   return m_graphicsLayer.get();
> +    };
> +
> +    auto* layerForPerspective = layerForChildrenTransform();

If you wanted to be fancy you could return both perspectiveRelativeBox and
layer together with something like

    return std::make_tuple(m_graphicsLayer.get(), borderBoxRect);
}

auto [layerForPerspective, perspectiveRelativeBox] =
layerForChildrenTransform()