[webkit-reviews] review granted: [Bug 211824] Add SPI for reverting to touch events for iPad trackpad interactions : [Attachment 399241] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 211824: Add SPI for reverting to touch events for iPad trackpad
interactions
https://bugs.webkit.org/show_bug.cgi?id=211824

Attachment 399241: Patch

https://bugs.webkit.org/attachment.cgi?id=399241&action=review




--- Comment #6 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 399241
  --> https://bugs.webkit.org/attachment.cgi?id=399241
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399241&action=review

lots of plumbing, I wish it could be a default that could be set/read, but I
know that those systems aren't a broad as is probably needed for this.

> Source/WebKit/ChangeLog:8
> +

A note maybe about being covered by existing tests + one new test?

> Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:59
> +#if TARGET_OS_IPHONE

why not #if ENABLE(IOS_TOUCH_EVENTS)?