[webkit-reviews] review denied: [Bug 211819] Fix MobileMiniBrowser build without internal SDK : [Attachment 399207] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 18:32:18 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has denied James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 211819: Fix MobileMiniBrowser build without internal SDK
https://bugs.webkit.org/show_bug.cgi?id=211819

Attachment 399207: Patch

https://bugs.webkit.org/attachment.cgi?id=399207&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 399207
  --> https://bugs.webkit.org/attachment.cgi?id=399207
Patch

Please don’t modify the project, such settings should be in xcconfigs. 

I’m not sure if this is the right fix even in xcconfigs, what do other projects
do?


More information about the webkit-reviews mailing list