[webkit-reviews] review granted: [Bug 211760] [WebAuthn] Don't assume extensions always exist : [Attachment 399087] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 211760: [WebAuthn] Don't assume extensions always exist
https://bugs.webkit.org/show_bug.cgi?id=211760

Attachment 399087: Patch

https://bugs.webkit.org/attachment.cgi?id=399087&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 399087
  --> https://bugs.webkit.org/attachment.cgi?id=399087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399087&action=review

> Source/WebKit/ChangeLog:3
> +	   [WebAuthn] Don't assume extensions always exist

The ASSERT_NOT_REACHED implies that we do assume these extensions exist.

I guess you mean don't treat this as a failure? But if this is a valid case, I
would suggest not having the asserts.