[webkit-reviews] review granted: [Bug 211759] Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate : [Attachment 399156] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 12 15:22:36 PDT 2020
Jer Noble <jer.noble at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 211759: Give some NetworkLoadMetrics to WebCoreNSURLSession's delegate
https://bugs.webkit.org/show_bug.cgi?id=211759
Attachment 399156: Patch
https://bugs.webkit.org/attachment.cgi?id=399156&action=review
--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 399156
--> https://bugs.webkit.org/attachment.cgi?id=399156
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399156&action=review
> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:44
> + if (!fetchStart.value())
Nit: .value() is superfluous here.
> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:48
> + return [NSDate dateWithTimeIntervalSince1970:fetchStart.value() +
delta.value()];
Nit: If it were me, i'd have used .seconds() instead of .value(), but NBD,
since those two methods are identical.
More information about the webkit-reviews
mailing list