[webkit-reviews] review granted: [Bug 211799] catch_mach_exception_raise_state() should fail early if the faulting address is not of interest. : [Attachment 399182] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 211799: catch_mach_exception_raise_state() should fail early if the
faulting address is not of interest.
https://bugs.webkit.org/show_bug.cgi?id=211799

Attachment 399182: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=399182&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 399182
  --> https://bugs.webkit.org/attachment.cgi?id=399182
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=399182&action=review

r=me

> Source/WTF/wtf/threads/Signals.cpp:181
> +    if ((exceptionType == EXC_BAD_ACCESS) && (exceptionData[1] &
invalidAddressMask))

can this code be moved below so we can use "faultingAddress" below?

> Source/WTF/wtf/threads/Signals.cpp:183
> +    compilerFence();

this doesn't seem necessary