[webkit-reviews] review granted: [Bug 211808] [WK2] Neuter WKFrameIsFrameSet() / WKPageGetFrameSetLargestFrame() C API : [Attachment 399181] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 211808: [WK2] Neuter WKFrameIsFrameSet() / WKPageGetFrameSetLargestFrame()
C API
https://bugs.webkit.org/show_bug.cgi?id=211808

Attachment 399181: Patch

https://bugs.webkit.org/attachment.cgi?id=399181&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 399181
  --> https://bugs.webkit.org/attachment.cgi?id=399181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399181&action=review

> Source/WebKit/UIProcess/API/C/WKFrame.cpp:125
>  bool WKFrameIsFrameSet(WKFrameRef frameRef)

Is there an "SPI deprecation" thing to be done?

> Source/WebKit/UIProcess/API/C/WKPage.cpp:393
> -    return toAPI(toImpl(pageRef)->frameSetLargestFrame());
> +    return nullptr;

Would it be safer to return the main frame rather than null?