[webkit-reviews] review granted: [Bug 211701] -Wtype-limits warning spam from CCallHelpers.h : [Attachment 399179] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 211701: -Wtype-limits warning spam from CCallHelpers.h
https://bugs.webkit.org/show_bug.cgi?id=211701

Attachment 399179: Patch

https://bugs.webkit.org/attachment.cgi?id=399179&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 399179
  --> https://bugs.webkit.org/attachment.cgi?id=399179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399179&action=review

> Source/JavaScriptCore/jit/CCallHelpers.h:103
> +	   if constexpr (!!NumberOfRegisters) {

I don’t think we need the !!

> Source/JavaScriptCore/jit/CCallHelpers.h:320
> +	   if constexpr (!!TargetSize) {

Ditto.