[webkit-reviews] review granted: [Bug 211802] Make editing/spelling/editing-word-with-marker-2.html test what it claims and make it work on iOS : [Attachment 399173] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 12 14:14:56 PDT 2020
Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 211802: Make editing/spelling/editing-word-with-marker-2.html test what it
claims and make it work on iOS
https://bugs.webkit.org/show_bug.cgi?id=211802
Attachment 399173: Patch
https://bugs.webkit.org/attachment.cgi?id=399173&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 399173
--> https://bugs.webkit.org/attachment.cgi?id=399173
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review
> LayoutTests/editing/spelling/editing-word-with-marker-2.html:13
> + + "is added before or after the misspelled word or the caret is moved."
> + + "The test succeeds if the word 'meagesga' has a red underline.");
Space after the period before the next sentence?
> LayoutTests/editing/spelling/editing-word-with-marker-2.html:57
> + debug(`<br>Test: ${testCase.testName}:`);
Does \n work too or do you have to use <br>?
More information about the webkit-reviews
mailing list