[webkit-reviews] review granted: [Bug 211795] [iOS] Port Foreground process assertion to RunningBoard : [Attachment 399157] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 211795: [iOS] Port Foreground process assertion to RunningBoard
https://bugs.webkit.org/show_bug.cgi?id=211795

Attachment 399157: Patch

https://bugs.webkit.org/attachment.cgi?id=399157&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 399157
  --> https://bugs.webkit.org/attachment.cgi?id=399157
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399157&action=review

r=me

> Source/WebKit/Configurations/WebKit.xcconfig:60
> +// FIXME: It is unnecessary to link against AssertionServices with the
latest SDK for the following platforms too.
> +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework
AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices;

Is this about building using the old SDK? (Do we do that?)