[webkit-reviews] review granted: [Bug 208207] [JSC] Support delete by val/id IC on 32-bits : [Attachment 399036] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 208207: [JSC] Support delete by val/id IC on 32-bits
https://bugs.webkit.org/show_bug.cgi?id=208207

Attachment 399036: Patch

https://bugs.webkit.org/attachment.cgi?id=399036&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 399036
  --> https://bugs.webkit.org/attachment.cgi?id=399036
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399036&action=review

r=me

>>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1175
>>> +	     JSValueOperand key(this, node->child2(),
ManualOperandSpeculation);
>> 
>> do we ever pick anything besides UntypedUse? Where is our speculation?
> 
> IIUC, we have rules to fix up to CellUse from fix up phase. The speculation
is just above at line 1172.

I see. This style is weird, we typically speculate after such a LOC. (I
understand you're just refactoring the code here)