[webkit-reviews] review granted: [Bug 211784] -Wattribute warning in BreakLines.cpp : [Attachment 399135] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 211784: -Wattribute warning in BreakLines.cpp
https://bugs.webkit.org/show_bug.cgi?id=211784

Attachment 399135: Patch

https://bugs.webkit.org/attachment.cgi?id=399135&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 399135
  --> https://bugs.webkit.org/attachment.cgi?id=399135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399135&action=review

> Source/WebCore/ChangeLog:8
> +	   Don't export lineBreakTable. It's not used outside WebCore anyway.

This comment is not accurate; it’s not what is done by this patch. Removing the
WEBCORE_EXPORT from the definition does not change whether lineBreakTable is
exported. That’s decided by the WEBCORE_EXPORT on the declaration in the
header.

I don’t know if lineBreakTable is used outside WebCore; to find out we’d have
to check on the callers of all the WebCore inline functions that use
lineBreakTable. If any of them are called outside WebCore, then it *is* used
outside.

If we wanted to not export it, then we’d have to remove the WEBCORE_EXPORT from
the header.

Removing this export from the .cpp file does seem like an acceptable way to fix
the warning, so r=me on the code change, but please change this change log
comment.