[webkit-reviews] review granted: [Bug 211785] [Wheel event region] Add support for getting wheel event region from ScrollingTree : [Attachment 399142] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 10:42:38 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 211785: [Wheel event region] Add support for getting wheel event region
from ScrollingTree
https://bugs.webkit.org/show_bug.cgi?id=211785

Attachment 399142: patch

https://bugs.webkit.org/attachment.cgi?id=399142&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 399142
  --> https://bugs.webkit.org/attachment.cgi?id=399142
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399142&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:106
> +		   return eventRegion &&
eventRegion->contains(IntPoint(localPoint));

Maybe roundedIntPoint()?

> Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:216
> +    return eventRegion->eventListenerRegionTypesForPoint(IntPoint(point));

roundedIntPoint?


More information about the webkit-reviews mailing list