[webkit-reviews] review granted: [Bug 211783] -Wsign-compare warnings in FTLLowerDFGToB3.cpp and DFGSpeculativeJIT.cpp : [Attachment 399134] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 211783: -Wsign-compare warnings in FTLLowerDFGToB3.cpp and
DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=211783

Attachment 399134: Patch

https://bugs.webkit.org/attachment.cgi?id=399134&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 399134
  --> https://bugs.webkit.org/attachment.cgi?id=399134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399134&action=review

r=me because I don’t see a better solution

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3600
>> +	    static_assert(JSValue::BigInt32Mask ==
static_cast<int64_t>(0xfffe000000000012));
> 
> Would using a "ll" suffix suffice?  0xfffe000000000012ll

I think that won’t work because the value doesn’t fit in a 64-bit long long,
and so the language makes it unsigned long long in that case. I consulted
https://en.cppreference.com/w/cpp/language/integer_literal to explore this.