[webkit-reviews] review granted: [Bug 211781] [Flatpak SDK] Craft a custom sccache config file from SDK toolchains : [Attachment 399128] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 211781: [Flatpak SDK] Craft a custom sccache config file from SDK
toolchains
https://bugs.webkit.org/show_bug.cgi?id=211781

Attachment 399128: Patch

https://bugs.webkit.org/attachment.cgi?id=399128&action=review




--- Comment #6 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 399128
  --> https://bugs.webkit.org/attachment.cgi?id=399128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399128&action=review

>> Tools/flatpak/flatpakutils.py:873
>> +		sccache_config = {'dist': {'scheduler_url':
'https://sccache.igalia.com',
> 
> What about?:
> 
>   `sccache_config = {'dist': {'scheduler_url': sccache_scheduler,`
> 
> with:
> 
>   `general.add_argument("-s", "--sccache-scheduler",
dest="sccache_scheduler", default='https://sccache.igalia.com')`

I like this suggestion of making the url configurable

> Tools/flatpak/flatpakutils.py:874
> +					  'toolchain_cache_size': 5368709120,

The default seems to be 10GB. Why lowering it to 5GB?