[webkit-reviews] review granted: [Bug 211749] [bmalloc][WTF] Add computing memory size implementation for FreeBSD : [Attachment 399063] PATCH

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 211749: [bmalloc][WTF] Add computing memory size implementation for FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=211749

Attachment 399063: PATCH

https://bugs.webkit.org/attachment.cgi?id=399063&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 399063
  --> https://bugs.webkit.org/attachment.cgi?id=399063
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=399063&action=review

r=me

> Source/WTF/wtf/RAMSize.cpp:60
>      sysinfo(&si);

Should we assert that the return value here is zero (similar to what bmalloc
does)?

Would also be nice to use `info` like bmalloc.

Neither of these are necessary to land this patch.