[webkit-reviews] review denied: [Bug 211756] Fix build errors after r260992 : [Attachment 399072] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 211756: Fix build errors after r260992
https://bugs.webkit.org/show_bug.cgi?id=211756

Attachment 399072: Patch

https://bugs.webkit.org/attachment.cgi?id=399072&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 399072
  --> https://bugs.webkit.org/attachment.cgi?id=399072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399072&action=review

Nice catch! I think putting "JSC::" to JSC_TO_STRING_TAG_WITHOUT_TRANSITION is
better if this macro is used in WebCore side too.

> Source/WebCore/ChangeLog:10
> +	   Introduce JSC::PropertyAttribute into
WebCore::JSDOMIteratorPrototype() since
> +	   PropertyAttribute is used without JSC namespace specifier there
> +	   by JSC_TO_STRING_TAG_WITHOUT_TRANSITION() macro.

Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side.