[webkit-reviews] review granted: [Bug 211540] GetArrayLength should be "blessed" during Fixup phase in the DFG : [Attachment 399043] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 211540: GetArrayLength should be "blessed" during Fixup phase in the DFG
https://bugs.webkit.org/show_bug.cgi?id=211540

Attachment 399043: Patch

https://bugs.webkit.org/attachment.cgi?id=399043&action=review




--- Comment #17 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 399043
  --> https://bugs.webkit.org/attachment.cgi?id=399043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399043&action=review

r=me. Seems like you need to rebase

> Source/JavaScriptCore/ChangeLog:9
> +	   to be configured during Fixup, then right now we will fail for

Fail how?

> Source/JavaScriptCore/assembler/testmasm.cpp:2198
> +static void testBranchIfNotType()

You could also have a microbenchmark too

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2032
> +	       node->setArrayMode(arrayMode);

It’s nice to have that assert you proposed. Maybe even in the DFG spec JIT /
FTL lower. But here works too