[webkit-reviews] review granted: [Bug 211645] Enable the mock video presentation mode in related layout tests and fix test failures : [Attachment 398985] WIP patch v4

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 211645: Enable the mock video presentation mode in related layout tests and
fix test failures
https://bugs.webkit.org/show_bug.cgi?id=211645

Attachment 398985: WIP patch v4

https://bugs.webkit.org/attachment.cgi?id=398985&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 398985
  --> https://bugs.webkit.org/attachment.cgi?id=398985
WIP patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=398985&action=review

> Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:226
> +    return (mode == HTMLMediaElementEnums::VideoFullscreenModeStandard) ||
(mode == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture &&
supportsPictureInPicture());

Too many parentheses here.

> LayoutTests/media/media-fullscreen-loop-inline.html:22
> +	   window.internals.settings.setAllowsInlineMediaPlayback(false);
> +	  
window.internals.settings.setAllowsInlineMediaPlaybackAfterFullscreen(true);
> +	   // Disable the Fullscreen API (element fullscreen) support
> +	   window.internals.settings.setFullScreenEnabled(false);
> +	   window.internals.setMockVideoPresentationModeEnabled(true);
> +	   window.internals.setMediaElementRestrictions(video,
"NoRestrictions");

These should all be just "internals", not "window.internals".

> LayoutTests/media/media-fullscreen-pause-inline.html:23
> +	   window.internals.settings.setAllowsInlineMediaPlayback(false);
> +	  
window.internals.settings.setAllowsInlineMediaPlaybackAfterFullscreen(true);
> +	   // Disable the Fullscreen API (element fullscreen) support
> +	   window.internals.settings.setFullScreenEnabled(false);
> +	   window.internals.setMockVideoPresentationModeEnabled(true);
> +	   window.internals.setMediaElementRestrictions(video,
"NoRestrictions");

Ditto.

> LayoutTests/media/media-fullscreen-return-to-inline.html:23
> +	   window.internals.settings.setAllowsInlineMediaPlayback(false);
> +	  
window.internals.settings.setAllowsInlineMediaPlaybackAfterFullscreen(false);
> +	   // Disable the Fullscreen API (element fullscreen) support
> +	   window.internals.settings.setFullScreenEnabled(false);
> +	   window.internals.setMockVideoPresentationModeEnabled(true);

Ditto.