[webkit-reviews] review granted: [Bug 211673] [macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips the submit button : [Attachment 398949] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211673: [macOS] Search field on
mayoclinic.org/forms/us-resident-appointment clips the submit button
https://bugs.webkit.org/show_bug.cgi?id=211673

Attachment 398949: Patch

https://bugs.webkit.org/attachment.cgi?id=398949&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 398949
  --> https://bugs.webkit.org/attachment.cgi?id=398949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:869
> -    if (style.appearance() == TextFieldPart || style.appearance() ==
TextAreaPart || style.appearance() == ListboxPart)
> +    if (style.appearance() == TextFieldPart || style.appearance() ==
TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() ==
ListboxPart)

At what point do we store appearance in a local to neaten this up?