[webkit-reviews] review granted: [Bug 211671] Fix base64.any.html test : [Attachment 398936] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 211671: Fix base64.any.html test
https://bugs.webkit.org/show_bug.cgi?id=211671

Attachment 398936: Patch

https://bugs.webkit.org/attachment.cgi?id=398936&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 398936
  --> https://bugs.webkit.org/attachment.cgi?id=398936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398936&action=review

> Source/WebCore/loader/ResourceLoader.cpp:278
> +    auto mode = DataURLDecoder::Mode::Default;
> +    if (m_request.requester() == ResourceRequest::Requester::Fetch)
> +	   mode = DataURLDecoder::Mode::ForgivingBase64;

In this context, the name ForgivingBase64 isn’t great. The reason is that this
is actually *stricter* than the default. Maybe the other mode needs a name
other than "Default"?