[webkit-reviews] review granted: [Bug 211656] Streamline MarkupAccumulator to improve efficiency a bit : [Attachment 398926] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 211656: Streamline MarkupAccumulator to improve efficiency a bit
https://bugs.webkit.org/show_bug.cgi?id=211656

Attachment 398926: Patch

https://bugs.webkit.org/attachment.cgi?id=398926&action=review




--- Comment #5 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 398926
  --> https://bugs.webkit.org/attachment.cgi?id=398926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398926&action=review

> Source/WebCore/editing/MarkupAccumulator.h:75
> +    template<typename ...StringTypes> void append(StringTypes... strings) {
m_markup.append(strings...); }

Any reason why StringTypes isn't a forwarding reference, and why you're not
using std::forward in the call?