[webkit-reviews] review granted: [Bug 211656] Streamline MarkupAccumulator to improve efficiency a bit : [Attachment 398926] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 9 08:55:14 PDT 2020

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 211656: Streamline MarkupAccumulator to improve efficiency a bit

Attachment 398926: Patch


--- Comment #5 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 398926
  --> https://bugs.webkit.org/attachment.cgi?id=398926

View in context: https://bugs.webkit.org/attachment.cgi?id=398926&action=review

> Source/WebCore/editing/MarkupAccumulator.h:75
> +    template<typename ...StringTypes> void append(StringTypes... strings) {
m_markup.append(strings...); }

Any reason why StringTypes isn't a forwarding reference, and why you're not
using std::forward in the call?

More information about the webkit-reviews mailing list