[webkit-reviews] review granted: [Bug 208875] [WebGL2] Complete new texture upload entry points in WebGL2RenderingContext : [Attachment 398652] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 208875: [WebGL2] Complete new texture upload entry points in
WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=208875

Attachment 398652: Patch

https://bugs.webkit.org/attachment.cgi?id=398652&action=review




--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 398652
  --> https://bugs.webkit.org/attachment.cgi?id=398652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398652&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:964
> +    case GraphicsContextGL::TEXTURE_BASE_LEVEL:
> +	   FALLTHROUGH;
> +    case GraphicsContextGL::TEXTURE_MAX_LEVEL:
> +	   FALLTHROUGH;
> +    case GraphicsContextGL::TEXTURE_COMPARE_FUNC:
> +	   FALLTHROUGH;
> +    case GraphicsContextGL::TEXTURE_COMPARE_MODE:
> +	   FALLTHROUGH;
> +    case GraphicsContextGL::TEXTURE_IMMUTABLE_LEVELS:
> +	   FALLTHROUGH;

I thought you only had to put FALLTHROUGH if you also had content in the case
block?

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:976
> +    case GraphicsContextGL::TEXTURE_MIN_LOD:
> +	   FALLTHROUGH;

Ditto.