[webkit-reviews] review granted: [Bug 209265] Implement web-share v2 for files : [Attachment 398880] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 8 12:42:43 PDT 2020


Andy Estes <aestes at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 209265: Implement web-share v2 for files
https://bugs.webkit.org/show_bug.cgi?id=209265

Attachment 398880: Patch

https://bugs.webkit.org/attachment.cgi?id=398880&action=review




--- Comment #29 from Andy Estes <aestes at apple.com> ---
Comment on attachment 398880
  --> https://bugs.webkit.org/attachment.cgi?id=398880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398880&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:305
> +    quarantineError = qtn_file_apply_to_path(fq,
fileURL.fileSystemRepresentation);

Do we need to return NO if this fails?


More information about the webkit-reviews mailing list