[webkit-reviews] review granted: [Bug 211603] Limit HTTP referer to 4kb : [Attachment 398811] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 8 10:21:21 PDT 2020


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 211603: Limit HTTP referer to 4kb
https://bugs.webkit.org/show_bug.cgi?id=211603

Attachment 398811: Patch

https://bugs.webkit.org/attachment.cgi?id=398811&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 398811
  --> https://bugs.webkit.org/attachment.cgi?id=398811
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398811&action=review

>>> Source/WebCore/ChangeLog:9
>>> +	     Use the origin if it's longer, unless the origin is too long.
>> 
>> What do other browsers do?
> 
> They do this.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1557346

Please update the change log to indicate that.

> Source/WebCore/platform/network/ResourceRequestBase.cpp:382
> +	   String origin = SecurityOrigin::create(URL(URL(),
httpReferrer))->toString();

Please add release logging (maybe even release error logging) to indicate that
this is happening, in case we have to investigate regressions caused by this.


More information about the webkit-reviews mailing list