[webkit-reviews] review granted: [Bug 211524] Preserve character set information when writing to the pasteboard when copying rich text : [Attachment 398819] Address feedback

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211524: Preserve character set information when writing to the pasteboard
when copying rich text
https://bugs.webkit.org/show_bug.cgi?id=211524

Attachment 398819: Address feedback

https://bugs.webkit.org/attachment.cgi?id=398819&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 398819
  --> https://bugs.webkit.org/attachment.cgi?id=398819
Address feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=398819&action=review

> Source/WebCore/editing/MarkupAccumulator.h:72
> +    bool isAllASCII() const { return
m_markup.toStringPreserveCapacity().isAllASCII(); }

We can follow up and make a much more efficient version of this. Fine to land
like this I suppose.

> Source/WebCore/editing/markup.cpp:248
> +	   m_reversedPrecedingMarkup.append("<meta charset=\"UTF-8\">");

Should add a _s here, I think. It’s more efficient to create a String from an
ASCIILiteral, since it doesn’t copy the characters.