[webkit-reviews] review canceled: [Bug 211591] [iOS] caret appears in the middle of a search field when field is focused on agoda.com : [Attachment 398799] Rebase on trunk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 8 07:07:55 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211591: [iOS] caret appears in the middle of a search field when field is
focused on agoda.com
https://bugs.webkit.org/show_bug.cgi?id=211591

Attachment 398799: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=398799&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 398799
  --> https://bugs.webkit.org/attachment.cgi?id=398799
Rebase on trunk

(In reply to Antoine Quint from comment #4)
> I'd rather we didn't add the animationDidFinish() method on
> AnimationEffect/KeyframeEffect. The other animationDid*() method are there
> because KeyframeEffect need to update accelerated animations based on a
> timing change in its associated WebAnimation, but here this is not the case.
> I suggest we simply call through KeyframeEffect to obtain the target right
> from WebAnimation::finishNotificationSteps() leaving
> AnimationEffect/KeyframeEffect untouched.

����


More information about the webkit-reviews mailing list