[webkit-reviews] review granted: [Bug 211600] Crash under WebKit::XPCServiceMain : [Attachment 398806] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 211600: Crash under WebKit::XPCServiceMain
https://bugs.webkit.org/show_bug.cgi?id=211600

Attachment 398806: Patch

https://bugs.webkit.org/attachment.cgi?id=398806&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 398806
  --> https://bugs.webkit.org/attachment.cgi?id=398806
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398806&action=review

> Source/WebKit/ChangeLog:12
> +	   - Crash under strcmp() could in theory happen if
expectedBundleVersion.UTF8String was null, which could
> +	     happen if expectedBundleVersion was null. I now use higher level
String types for the versions, make
> +	     sure they are not null and use String comparison to compare them.

I understand how checks for null are a good idea. Not sure why using
WTF::String is helpful.