[webkit-reviews] review granted: [Bug 211232] [Web Animations] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is a flaky failure : [Attachment 398775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 13:12:43 PDT 2020

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 211232: [Web Animations]
d-send-events.html is a flaky failure

Attachment 398775: Patch


--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 398775
  --> https://bugs.webkit.org/attachment.cgi?id=398775

View in context: https://bugs.webkit.org/attachment.cgi?id=398775&action=review

> Source/WebCore/ChangeLog:17
> +	   It would sometime happen that animA in one frame and animB in
another, when they should always finished in sync. Thus animA.finished would
> +	   resolve and animB.cancel() would be called, rejecting
animB.finished. This happened because animB was attached to a DocumentTimeline
> +	   by script which isn't the main DocumenTimeline accessed via
document.timeline. Some curious code would handle syncing of the various
> +	   such that they would use a shared timebase. This was in

Sometimes, animA and animB would finish in different frames even though they
were designed to finish at the same time. If this happened, animA.finished
would resolve and trigger animB.cancel, which then rejected animB.finished.

> Source/WebCore/ChangeLog:28
> +	   We now move the currentTime caching at the
DocumentTimelinesController level which ensures all DocumentTimeline objects
attached to a given
> +	   Document use the exact same currentTime(). This prompted some
overdue refactoring where also all the related animation suspension code is
> +	   from DocumentTimeline up to DocumentTimelinesController.

Again, I don't understand how you manage to have such a large value for your
line wrapping mark :)

View -> Edit -> Wrap Column

More information about the webkit-reviews mailing list