[webkit-reviews] review granted: [Bug 211585] [macOS] Playhead in Touch Bar continues when loading stalls : [Attachment 398771] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 211585: [macOS] Playhead in Touch Bar continues when loading stalls
https://bugs.webkit.org/show_bug.cgi?id=211585

Attachment 398771: Patch

https://bugs.webkit.org/attachment.cgi?id=398771&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 398771
  --> https://bugs.webkit.org/attachment.cgi?id=398771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review

> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146
> +	   bool isPlaying = this->isPlaying() && !this->isStalled();

No need for the second "this->". The first one is needed because of a conflict
with the name of the local variable we are setting.

> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436
> +    return m_mediaElement ? m_mediaElement->readyState() <=
HTMLMediaElement::HAVE_CURRENT_DATA : false;

I like using && for expressions like this one.