[webkit-reviews] review granted: [Bug 211398] Google Maps rendering corruption in simulator with ANGLE : [Attachment 398412] Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride.

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 211398: Google Maps rendering corruption in simulator with ANGLE
https://bugs.webkit.org/show_bug.cgi?id=211398

Attachment 398412: Fix Google Maps rendering corruption in simulator. Respect
IOSurface row stride.

https://bugs.webkit.org/attachment.cgi?id=398412&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 398412
  --> https://bugs.webkit.org/attachment.cgi?id=398412
Fix Google Maps rendering corruption in simulator. Respect IOSurface row
stride.

View in context: https://bugs.webkit.org/attachment.cgi?id=398412&action=review

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:8
6
> +	 mRowStrideInPixels(0),

Don't you use initializer lists in the header in ANGLE?

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:9
8
> +    // Hopefully the number of bytes per row is always an integer number of
pixels.

I'd put a blank line above this, but that can also be done upstream.