[webkit-reviews] review denied: [Bug 211539] SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN : [Attachment 398689] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pinki Gyanchandani
<pgyanchandani at apple.com>'s request for review:
Bug 211539: SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
https://bugs.webkit.org/show_bug.cgi?id=211539

Attachment 398689: Patch

https://bugs.webkit.org/attachment.cgi?id=398689&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 398689
  --> https://bugs.webkit.org/attachment.cgi?id=398689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398689&action=review

> Source/WebCore/rendering/shapes/Shape.cpp:196
> +	   // RELEASE_ASSERT(imageData && imageData->data());

Please don't check in commented out code.

> Source/WebCore/rendering/shapes/Shape.cpp:197
> +	   if (imageData && imageData->data()) {

Make this an early return.