[webkit-reviews] review granted: [Bug 211525] Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code : [Attachment 398646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 07:03:14 PDT 2020


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 211525: Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
https://bugs.webkit.org/show_bug.cgi?id=211525

Attachment 398646: Patch

https://bugs.webkit.org/attachment.cgi?id=398646&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 398646
  --> https://bugs.webkit.org/attachment.cgi?id=398646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340
> -void PageClientImpl::registerInsertionUndoGrouping()

Surprised that this can be removed when registerInsertionUndoGrouping() is pure
virtual...


More information about the webkit-reviews mailing list