[webkit-reviews] review granted: [Bug 211543] Fix ArrayMode nodes after r261260 : [Attachment 398695] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 211543: Fix ArrayMode nodes after r261260
https://bugs.webkit.org/show_bug.cgi?id=211543

Attachment 398695: Patch

https://bugs.webkit.org/attachment.cgi?id=398695&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 398695
  --> https://bugs.webkit.org/attachment.cgi?id=398695
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398695&action=review

r=me with nits

> Source/JavaScriptCore/dfg/DFGClobberize.h:162
> +    // all nodes with an ArrayMode can clobber top. We make an exception for
CheckArray since it has no effects.
> +    if (graph.m_planStage < PlanStage::AfterFixup && node->hasArrayMode() &&
node->op() != CheckArray)
>	   return clobberTop();

Can we list up all ArrayMode nodes here not to forget adding some nodes?

Like this.

if (graph.m_planStage < PlanStage::AfterFixup && node->hasArrayMode()) {
    switch (node->op()) {
    case GetIndexedPropertyStorage:
    ...
	break;
    case CheckArray:
	return clobberTop();
    default:
	DFG_ASSERT(...);
    }
}

Do we need to include CheckArrayOrEmpty too?