[webkit-reviews] review granted: [Bug 211543] Fix ArrayMode nodes after r261260 : [Attachment 398695] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 6 19:37:43 PDT 2020

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 211543: Fix ArrayMode nodes after r261260

Attachment 398695: Patch


--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 398695
  --> https://bugs.webkit.org/attachment.cgi?id=398695

View in context: https://bugs.webkit.org/attachment.cgi?id=398695&action=review

r=me with nits

> Source/JavaScriptCore/dfg/DFGClobberize.h:162
> +    // all nodes with an ArrayMode can clobber top. We make an exception for
CheckArray since it has no effects.
> +    if (graph.m_planStage < PlanStage::AfterFixup && node->hasArrayMode() &&
node->op() != CheckArray)
>	   return clobberTop();

Can we list up all ArrayMode nodes here not to forget adding some nodes?

Like this.

if (graph.m_planStage < PlanStage::AfterFixup && node->hasArrayMode()) {
    switch (node->op()) {
    case GetIndexedPropertyStorage:
    case CheckArray:
	return clobberTop();

Do we need to include CheckArrayOrEmpty too?

More information about the webkit-reviews mailing list