[webkit-reviews] review granted: [Bug 211529] [ContentObservation] Shutterstock search bar is not activated on the first tap : [Attachment 398663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 6 14:56:25 PDT 2020

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 211529: [ContentObservation] Shutterstock search bar is not activated on
the first tap

Attachment 398663: Patch


--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 398663
  --> https://bugs.webkit.org/attachment.cgi?id=398663

View in context: https://bugs.webkit.org/attachment.cgi?id=398663&action=review

> Source/WebKit/ChangeLog:12
> +	   Itâs very difficult to eliminate such false positives since all we
see is that some (actionable)content is going away while some
(actionable)content is being created.


> Source/WebCore/page/Quirks.cpp:808
> +    return isFirstSyntheticClickOnPage &&
(equalLettersIgnoringASCIICase(host, "shutterstock.com") ||

Surprised we don't have a helper for (equalLettersIgnoringASCIICase(host,
"shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com")) yet

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3301
> +    m_hasHandledSyntheticClick = false;

Maybe add a comment saying that this is only used for a quirk, otherwise our
future selves will forget.

More information about the webkit-reviews mailing list