[webkit-reviews] review granted: [Bug 211386] REGRESSION (r261056): [ Mac WK1 ] inspector/console/console-api.html is flaky crashing : [Attachment 398661] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 211386: REGRESSION (r261056): [ Mac WK1 ]
inspector/console/console-api.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=211386

Attachment 398661: Patch

https://bugs.webkit.org/attachment.cgi?id=398661&action=review




--- Comment #22 from Tim Horton <thorton at apple.com> ---
Comment on attachment 398661
  --> https://bugs.webkit.org/attachment.cgi?id=398661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398661&action=review

> Source/WebCore/ChangeLog:8
> +	   This bug was caused by the failure clear the delegate on an
NSScrollerImp when, for testing,

There is at least one missing or extra word here

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:185
> +	   [iter->value.get() setDelegate:nil];

.get() here? I'm not sure what `value` is , but hopefully unnecessary