[webkit-reviews] review granted: [Bug 211499] Make a helper for ICU functions that may need to be called twice to populate a buffer : [Attachment 398655] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 211499: Make a helper for ICU functions that may need to be called twice to
populate a buffer
https://bugs.webkit.org/show_bug.cgi?id=211499

Attachment 398655: Patch

https://bugs.webkit.org/attachment.cgi?id=398655&action=review




--- Comment #10 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 398655
  --> https://bugs.webkit.org/attachment.cgi?id=398655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398655&action=review

r=me pending EWS, this is really cool.

> Source/WTF/ChangeLog:10
> +	   specia considerations because of null character terminatorion, or
destinations that are

spelling: specia, terminatorion

> Source/WTF/wtf/unicode/icu/ICUHelpers.h:77
> +template<typename FirstArgumentType, typename ...OtherArgumentTypes> auto
argumentTuple(FirstArgumentType&&, OtherArgumentTypes&&...);

How come this declaration is needed for argumentTuple but not for findVector?