[webkit-reviews] review granted: [Bug 211272] ContextMenu: entire webpage pops and disappears to generate preview of embedded image : [Attachment 398650] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 211272: ContextMenu:  entire webpage pops and disappears to generate
preview of embedded image
https://bugs.webkit.org/show_bug.cgi?id=211272

Attachment 398650: Patch

https://bugs.webkit.org/attachment.cgi?id=398650&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 398650
  --> https://bugs.webkit.org/attachment.cgi?id=398650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398650&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9419
> +	   if (![strongSelf _canRemoveContextMenuView])
>	       return;
>	   [std::exchange(strongSelf->_contextMenuHintContainerView, nil)
removeFromSuperview];

Why not just call _removeContextMenuViewIfPossible here, and then
_canRemoveContextMenuView doesn't need to be separate?