[webkit-reviews] review granted: [Bug 211498] Cut and paste from Google Doc to Notes in several (non-Latin) languages doesn't work : [Attachment 398643] Address review feedback (2)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 211498: Cut and paste from Google Doc to Notes in several (non-Latin)
languages doesn't work
https://bugs.webkit.org/show_bug.cgi?id=211498

Attachment 398643: Address review feedback (2)

https://bugs.webkit.org/attachment.cgi?id=398643&action=review




--- Comment #22 from Darin Adler <darin at apple.com> ---
Comment on attachment 398643
  --> https://bugs.webkit.org/attachment.cgi?id=398643
Address review feedback (2)

Not thrilled that this makes things more complicated. Kind of liked just doing
it unconditionally. Not sure how we know we found all the places that
AddMetaCharsetIfNeeded is needed. Something about the AddMetaCharsetIfNeeded
name doesn’t seem perfect. It seems to concentrate too much on "which tag we
are adding" as opposed to "make string that will work if converted to UTF-8".
r=me as is, though